Problem with save-current-buffer and find-file

Question

I have a list of files that I want to successively visit with find-file and then return to the first buffer. I thought that save-current-buffer would help me to achieve this. However, with the following code, the cursor ends up in one of the buffers opened by find-file, not in the buffer where save-current-buffer had been executed:

(save-current-buffer
    (dolist (file org-agenda-files)
        (find-file file)
        ;; do something with file
        ))

How can I return to the first buffer after find-file?

Answer 1

save-current-buffer, like set-buffer, controls which buffer is the current-buffer.

But it does not deal with which buffers might be displayed and which windows might be selected.

find-file not only visits file contents in a buffer - it also displays the buffer and selects its window.

You might want find-file-noselect instead of find-file.

Answer 2

There are two options:

1) one could enhance my code example by calling switch-to-buffer after save-current-buffer in order to jump back to the saved buffer.

(save-current-buffer
    (dolist (file org-agenda-files)
        (find-file file)
        ;; do something with file
        ))
(switch-to-buffer (current-buffer))

2) one could go for YoungFrog's proposal that uses with-current-buffer and find-file-noselect:

(dolist (file org-agenda-files)
    (with-current-buffer (find-file-noselect file)
        ;; do something with file
        ))

In my view, both options are pretty much equivalent.