I've been using emacsclient for a good while now, and in the past I've always used C-x C-c out of habit. This has never been a problem when using
emacsclient -t as my terminal
EDITOR for entering git commit messages, for instance.
I'm not sure what's changed, but now when I do, say,
git commit, enter a message, save, and then C-x C-c like usual, it now complains
Don’t kill this buffer. Instead cancel using C-c C-k
But, when I use the suggested combination, it exits with status code 1 and git aborts the commit.
I really genuinely do want to kill this buffer and exit normally, so I'm a bit at a loss how to where this message is coming from, and how to fix it.
Update: Using C-c C-c does work, but I'd still like to use the usual key combo as the manual suggests I should be able to do. Is there a way to conditionally rebind C-x C-c to
(with-editor-finish), but only within client sessions?
I'm also still curious about what caused this to start behaving differently from how it has in the past.