How to use flush-lines in a script?

Question

I want to use flush-lines in a selected region, but I have troubles.

Here it is my code:

(defun delete-empty-lines ()
  "Delete empty lines in bibliography."
  (interactive)
  ;; set point-min
  (setq m1 (make-marker))
  (goto-char (point-min))
  (search-forward "\\begin{thebibliography}" nil nil)
  (beginning-of-line)
  (set-marker m1 (point))
  ;; set point-max
  (setq m2 (make-marker))
  (search-forward "\\end{thebibliography}" nil nil)
  (end-of-line)
  (set-marker m2 (point))
  ;; set marker
  (push-mark m1 nil t)
  (push-mark m2 nil t)
  ;; color region
  (setq mark-active t)
  ;; clean empty lines
  (flush-lines "$^" m1 m2)
  ;; decolor region
  (setq mark-active nil))

The line (flush-lines "$^" m1 m2) seems to be ignored when I call my function in emacs and I do not understand why... How can I fix my code?

Answer 1

"$^" will never match anything, so no lines will ever be flushed.

That has nothing to do with using it in a script -- the same thing will be evident if you attempted that interactively.

---

Perhaps you want something more like this?

(defun delete-empty-lines-in-bibliography ()
  "Delete empty lines in bibliography."
  (interactive)
  (save-excursion
    (goto-char (point-min))
    (save-match-data
      (while (search-forward "\\begin{thebibliography}" nil t)
        (let ((start (match-beginning 0)))
          (when (search-forward "\\end{thebibliography}" nil t)
            (save-excursion
              (flush-lines "^$" start (point)))))))))

Note how I am using let to remember the start position, without any need to use markers. A marker would be needed if there was any chance that the position could change before it was used, but that is not the case here, so we can safely (and sensibly) use a simpler approach.

Note also that if you do need to use markers for any valid reason, you should set them to nil when you are finished with them, otherwise they will continue to be tracked in the buffer (and hence consuming resources) after the function has finished. That is more of an issue with your code on account of your use of global variables -- m1 and m2 will continue to exist, and so garbage collection will never clean those markers up.