How to suppress warning about positional arguments in define-minor-mode

Question

I am on Emacs 28.0.5 and keep getting warnings about:

Warning: Use keywords rather than deprecated positional arguments to `define-minor-mode'

Unfortunately it is for packages I don't control like lsp-mode. I would like to suppress the warning using something like (I use radian Emacs config, hence the use of use-feature for Emacs-provided packages - imagine a require 'warnings if you are more familiar with that):

(use-feature warnings
   :config
   (add-to-list 'warning-suppress-log-types '(what-to-put-here?)))

but apparently I am not passing the type that warning-suppress-log-types expects for this warning to be picked up because it keeps happening when lsp-mode loads (I won't bore you with all the incantations that I've tried in 'what-to-put-here?'. If you read the source for define-minor-mode you'll see that the way the warning is generated is perhaps non-standard, i.e., it doesn't seem to call display-warning. Do you know a way to make it stop generating this message?

I'd do a pull request to lsp-mode, but I am an outlier by using such a bleeding edge Emacs version and I don't imagine they'll want to accommodate that version in the common case.

Note: I have filed an issue with lsp-mode in the meantime.

Answer 1

This is already fixed in 7.1 version - lsp-mode is now using the emacs new keyword syntax for minor modes.

Answer 2

Well, turns out radian Emacs config provides an advice for such things:

(dolist (func '(define-minor-mode))
  (advice-add func :around #'radian--advice-silence-messages))

which you can add to your init.local.el.

Here is its definition:

(defun radian--advice-silence-messages (func &rest args)
  "Invoke FUNC with ARGS, silencing all messages. This is an `:around' advice for many different functions."
  (cl-letf (((symbol-function #'message) #'ignore))
     (apply func args)))